Something that has both good and bad features.
mixed bag
Something tending to have both good and bad results or characteristics …
thick and thin
Both good and bad times.
cruel mistress
Something which has both significant positive and negative aspects.
boon and bane
Something that is both a benefit and an affliction.
a boon and a bane
mixed picture
A situation in which both negatives and positives are found.